Several years ago I spent a few hours implementing a feature in Mozilla, and then probably 10 times that amount of time dealing with the hassle of getting my code (which I was trying to give them for free) approved and into their sources. The incident left a bitter aftertaste.
Fast forward to present day. I was just reading through some WebKit sources and noticed a typo in one of the comments. So I decided to fix the typo and submit a patch to see how painful the process is for the competing project.
Index: JavaScriptCore/ChangeLog =================================================================== --- JavaScriptCore/ChangeLog (revision 42833) +++ JavaScriptCore/ChangeLog (working copy) @@ -1,3 +1,9 @@ +2009-04-24 Rob Raguet-Schofield + + Reviewed by NOBODY (OOPS!). + + * wtf/CurrentTime.h: + 2009-04-23 Mark Rowe With great sadness and a heavy heart I switch us back from YARR to WREC in Index: JavaScriptCore/wtf/CurrentTime.h =================================================================== --- JavaScriptCore/wtf/CurrentTime.h (revision 42833) +++ JavaScriptCore/wtf/CurrentTime.h (working copy) @@ -36,7 +36,7 @@ namespace WTF { // Returns the current system (UTC) time in seconds, starting January 1, 1970. // Precision varies depending on a platform but usually is as good or better - // then a millisecond. + // than a millisecond. double currentTime(); } // namespace WTF
Picky? Sure. But why not?
Update: patch approved after 5 hours.
No comments:
Post a Comment